search

miickel / gulp-angular-templatecache

Concatenates and registers AngularJS templates in the $templateCache.
MIT License
524 stars 103 forks source link

Updated gulp-header to 2.0.7 #170

Closed Jakooob closed 5 years ago

simonua commented 5 years ago

@Jakooob, thanks for the PR. Your package-lock contains a massive amount of dependency changes. When I update gulp-header from 2.0.5 to 2.0.7 on master, I only see gulp-header update. 

    "gulp-header": {
      "version": "2.0.7",
      "resolved": "https://registry.npmjs.org/gulp-header/-/gulp-header-2.0.7.tgz",
      "integrity": "sha512-qppGkYGQZnt/mRJiiR5wYZIUwNUn47Xpg4+6tHYDVeAW5IDLbHBQwbw7axfMLWGE+gKQpB+yXLeslHMw1/Haog==",
      "requires": {
        "concat-with-sourcemaps": "^1.1.0",
        "lodash.template": "^4.4.0",
        "map-stream": "0.0.7",
        "through2": "^2.0.0"
      }
    },

I'll be happy to do the update myself on a branch or wait for changes to your package-lock file.

Jakooob commented 5 years ago

Hi @simonua, thanks for fast feedback. Sorry for that massive change, is this better? This is my first PR to any open-source project :)

simonua commented 5 years ago

Hi @Jakooob, that's much better! Have you been able to successfully test this with 2.0.7?

simonua commented 5 years ago

All tests pass, and gulp-header's commit history from 2.0.5 to 2.0.7 doesn't immediately show anything of concern. I'm merging this. Thank you, @Jakooob.