search

miigotu / certbot-dns-godaddy

A godaddy dns plugin using lexicon for cerbot to authenticate and retrieve letsencrypt certificates
Other
133 stars 47 forks source link

no longer work with subdomain cert generation #56

Open blackjackyau opened 8 months ago

blackjackyau commented 8 months ago

believed this is cased by the recent refactoring work "refactor: use the new Lexicon-based plugin API"

certbot certonly \ --authenticator dns-godaddy \ --dns-godaddy-propagation-seconds 120 \ --dns-godaddy-credentials c.ini \ --keep-until-expiring --non-interactive --expand \ --server https://acme-v02.api.letsencrypt.org/directory \ --agree-tos --email ${{ secrets.EMAIL }} \ -d subdomain.domain.com

The request for domain cert will be rejected with error message

Requesting a certificate for subdomain.domain.com Error determining zone identifier for subdomain.domain.com: 404 Client Error: Not Found for url: https://api.godaddy.com/v1/domains/subdomain.domain.com. Ask for help or search for solutions at https://community.letsencrypt.org./ See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.

eduder commented 8 months ago

I'm also having this problem, 404 with the subdomain

miigotu commented 8 months ago

Broken in #52

You can pin to the previous version until this is resolved: https://github.com/miigotu/certbot-dns-godaddy/pull/52#issuecomment-1794348884

blackjackyau commented 8 months ago

yes, I have workaround it with this image tag miigotu/certbot-dns-godaddy:main08f79d83b312c6426787ccf5614122f0cbce429d

wafemand commented 7 months ago

Workaround for pip instalation: pip install -U certbot-dns-godaddy==2.6.0

mnejmantowicz commented 4 months ago

I just opened a new issue without reading this one. Apologies. The issue still persists. I have validated that @blackjackyau image tag does work. Any chance we can get this into the next build?