search

miigotu / certbot-dns-godaddy

A godaddy dns plugin using lexicon for cerbot to authenticate and retrieve letsencrypt certificates
Other
135 stars 48 forks source link

2.9.0 release ? #71

Open Deishelon opened 6 months ago

Deishelon commented 6 months ago

Hi,

If one is using nginx-proxy-manager, it will try to install this package, however using latest nginx-proxy-manager (2.11.1) with certbot 2.9.0 will fail with No matching distribution found for certbot-dns-godaddy==2.9.0

Looking at sources of nginx-proxy-manager, it's gonna install certbot-dns-godaddy==${certbot-version}. Ref

The way it gets certbot-version is by doing certbot --version Ref

Doing it on the latest nginx-proxy-manager, I get this:

$ docker exec -it 5042b6b961c1 /bin/bash

Version 2.11.1 (aec3020) 2024-02-28 22:33:06 UTC, OpenResty 1.21.4.3, debian 12 (bookworm), Certbot certbot 2.9.0
Base: debian:bookworm-slim, linux/amd64
Certbot: nginxproxymanager/nginx-full:latest, linux/amd64
Node: nginxproxymanager/nginx-full:certbot, linux/amd64

[root@docker-5042b6b961c1:/app]# certbot --version
certbot 2.9.0
[root@docker-5042b6b961c1:/app]#

So I think we effectively need release of this repo with version 2.9.0, or we open an issue in nginx-proxy-manager to use 2.8.0 (latest version of this repo at the time of writing)

Update: I should have checked nginx-proxy-manager repo for this issue. and indeed there is one: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3592

But I think the proposed solutions there (exec into container, and hack stuff is not a great solution, so opening a issue here to fix the root cause)

wolviex commented 6 months ago

I think that the root cause is that NPM has tied the version of this plugin to the version of Certbot. This will come up every single time there is an update to certbot. I've submitted a PR there to fix the root cause and pin NPM to use the latest certbot-dns-godaddy (2.8.0) https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3639

I've encountered another error, relating to certbot/plugins/dns_common_lexicon.py and the recent update about delegated subdomains, so try at your own risk.

miigotu commented 6 months ago

I think that the root cause is that NPM has tied the version of this plugin to the version of Certbot. This will come up every single time there is an update to certbot. I've submitted a PR there to fix the root cause and pin NPM to use the latest certbot-dns-godaddy (2.8.0) https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3639

I've encountered another error, relating to certbot/plugins/dns_common_lexicon.py and the recent update about delegated subdomains, so try at your own risk.

We need a workflow or bot here that automatically updates this package when certbot is updated, and tests it and then releases if someone wants to take that on.