mijorus / smile

An emoji picker for linux, with custom tags support and localization. I'll also put some random emojis here πŸ¦πŸΎπŸ¦”πŸ¦‡
https://mijorus.it/projects/smile
GNU General Public License v3.0
237 stars 13 forks source link

Categories appear cut off #22

Closed alba4k closed 1 year ago

alba4k commented 1 year ago

FIrst of all, congratulations to @mijorus for this awesome program!

Now I'd like to point out a couple of issues I'm having with it.

The first and major one, which I'm opening the issue for, is that the emoji categories appear cut off by the edge of the window, no matter the size of it: immagine immagine

Since it might be relevant, my current window manager is i3wm.

The second, smaller, thing is more of a feature request than a real issue: it would be quite nice if the program would use the system default emoji font (in my case, Joypixels) instead of noto (google) emojis.

Thanks a lot for the time spent creating this!

I also speak italian, answer however you're more comfortable doing
mijorus commented 1 year ago

Hi @alba4k ,

First of all, what kind of theme/distro are you using? (theme especially is relevant). Are you using the package from the AUR?

alba4k commented 1 year ago

I am using the AUR package, with an old catppuccin gtk theme (you don't find it anymore, but you can find it in my dotfiles)

You are right, I don't have this issue when using GTK_THEME="Adwaita" or "Adwaita:dark"

Do you have any idea of what could be causing this?

mijorus commented 1 year ago

I am using the AUR package, with an old catppuccin gtk theme (you don't find it anymore, but you can find it in my dotfiles)

You are right, I don't have this issue when using GTK_THEME="Adwaita" or "Adwaita:dark"

Do you have any idea of what could be causing this?

Yes, the AUR package.

And this is why this package is released only as a flatpak. (The AUR release is unofficial)

Because:

You are lucky with the second one, as on some older distros some emojis are not showing up correctly unless we are inside the Flatpak environment.

To sum it up:

mijorus commented 1 year ago

I'm expanding the answer a little bit.

Unicodes are updated every once in a while. In order to add features like skin tones , hairs , sex, flags and more, they have basically combined two emojis into one.

In this way, if you're trying to see this πŸ‘‹πŸΏ on older software, it would still be rendered as πŸ‘‹β¬›.

So, what if the user is on Ubuntu 18.04? If I was using the system font, The emoji grid would look terrible because some cells would contain two characters

alba4k commented 1 year ago

I had already noticed that some emojis are indeed composite (ineed by the use of some programs with an own emoji rendering), and I can see how this could be an issue, yes. I'm a bit hesitant with flatpak, as it would be the only flatpak package I would have installed (and maybe steam, because often games want "ubuntu" versions of some libraries), but I will look into it.

I wish you a great continuation :)

alba4k commented 1 year ago

immagine Well, things didn't go as expected. The exact same thing apparently happens with the flatpak aswell...

mijorus commented 1 year ago

Damn!πŸ˜…

alba4k commented 1 year ago

So, I guess it's just that theme being broken ahah!

I guess that you don't really like its existance, but would you mind if I keep it, so I don't need flatpak installed for just one package? :P

As for the custom ttf selection, should I open a different issue?

mijorus commented 1 year ago

There is no need, thanks

mijorus commented 1 year ago

Libadwaita should now address this issue