mijorus / smile

An emoji picker for linux, with custom tags support and localization. I'll also put some random emojis here πŸ¦πŸΎπŸ¦”πŸ¦‡
https://mijorus.it/projects/smile
GNU General Public License v3.0
237 stars 13 forks source link

App closes after picking an emoji #24

Closed sstendahl closed 1 year ago

sstendahl commented 1 year ago

I'm suspecting it might be by design, so I'm not really sure if it's a bug, but if I click an emoji, it copies it nicely to my clipboard but it also closes the application immediately. Personally I would prefer if it would keep the application open so that I can then directly find and copy another emoji.

If this is by design, possibly it would be a good alternative to make it a preference option? Just a switch/checkbox in the preferences menu?

Video related πŸ˜ƒ Screencast from 2023-01-10 12-58-17.webm

I'm running Fedora Silverblue 37 by the way, on the latest GNOME 43.2 build.

Edit: I also notice it keeps running in the background. As Smile is written in GTK, I expect it may be expecting to run within the GNOME environment, which by default doesn't have any app indicators. So on e.g. Fedora there's no way of telling it's still running in the background. I'm not trying to push GNOME HIG design guides on external applications, but just wanted to throw that out there.

mijorus commented 1 year ago

Hi @SjoerdB93 , first of all I just want to point out that a gtk4 is in the making, so I am currently busy on that and not planning any new feature release until it's done, except urgent bug fixes.

Let's now address your points:

Please see: https://github.com/mijorus/smile#multi-selection

sstendahl commented 1 year ago

Hi,

Thanks for the elaborate reply. To be honest, I was actually unaware that it was not running GTK4. I'm using the adw-gtk3 theme on my system, and it does a pretty good job of disguising GTK3 apps as if they were made with libadwaita. I absolutely agree that it's best to get that done first before working on any new features.

Regarding the issue here. It was mainly just that I was playing around with the application. I wanted to just select an emoji, copy this externally. Select another one, copy that externally etc.. and I had to keep restarting smile. If I want to use multiple different emojis though, I guess multi-selection works as well. I was honestly not aware that this was an option, should have read the readme. Perhaps having ctrl+mouse click would be a nice alternative also for the multi-selection option. As fully switching to keyboard while doing main operations with the mouse is a bit counter-intuitive.

Not sure if I'm the biggest fan of keeping it running in the background to save less than a second in launch time. It's not a lot of resources, but it's still there just taking 60 Mb of RAM when I'm not using it. But I guess that's a design decision. Maybe in the future it would be a nice to have that as on option.

Not that I'm some hard-core Smile poweruser. I just happened to stumble upon this on Flathub, and played around with it. Just wanted to give my general impression, not trying to say that my impression is the objective right one :)

mijorus commented 1 year ago

Shift + Click should be already available. @SjoerdB93

About the background service, multiple users have reported issues with this background activity on GNOME, I'm adding a toggle to change this behavior always in the next update.

I'm Leaving this bug opened until the release

mijorus commented 1 year ago

You can now set Run in the background to off on the latest version (v2.0.1) releasing on Flathub soon