search

mik3y / pymidi

Python library for building RTP-MIDI / AppleMIDI clients and servers
MIT License
47 stars 11 forks source link

Minor changes and additions #29

Open Brettles opened 1 year ago

Brettles commented 1 year ago

Some things that I found handy while using the code: Added log output for client latency (other RTP MIDI clients do this so I figured this was a good thing); a little bit of extra decoding for pitch blend commands; and passed the journal through to the handler because it was good to have for what I needed.

Great work on the code...

mik3y commented 1 year ago

PS: I just added some github actions to the repo. When you push this branch again you should see them run.

It's OK if the lint check fails - I will fix that subsequently (it's going to be a big diff, best not to mix it with your functional changes).

Brettles commented 1 year ago

No problems. Thanks for your patience - mostly a git and Python n00b. New PR inbound because I'm not sure if (how!) to update this one.

Brettles commented 1 year ago

...or it might have already done it. Sorry. Unsure. Looks like the commits are in there. Let me know if that isn't the case.

Brettles commented 1 year ago

Again apologies for my n00b-ness (because I think my next change got rolled into this PR).

Made a change to the client code - I'm still learning this RTP MIDI stuff but in all the other examples I've seen the client uses two source ports (one for control and one for MIDI) and they are generally allocated sequentially. This is now reflected in the client module by having two sockets rather than one. So far it seems to be working better with the other components I'm using; but more testing to come.

mik3y commented 1 year ago

Hey @Brettles, there's no need to make any apology for noobness! I think open source should be fun first and foremost; and good bit of that fun comes from learning as we go. I'm just happy you're diving in!

Just a quick heads up, I'm just headed out on a short vacation so I'm probably not going to be able to merge this until next week. So feel free to revise/tinker if you like until then.

Poke me again a week from now if I haven't jumped back in by the , thanks!

Brettles commented 1 year ago

No problems! Have made a bunch of other small changes. Will submit them... No rush. Enjoy your vacation!