search

mika / jenkins-debian-glue

Scripts for Debian package/repository handling inside Jenkins
MIT License
131 stars 91 forks source link

Don't remove source packages when building binary only packages #173

Closed laeti-tia closed 7 years ago

laeti-tia commented 7 years ago

When the MAIN_ARCHITECTURE or the host architecture doesn't match the package architecture, we build binary only packages by setting DEBBUILDOPTS to -B. But when looking at packages to remove from the repository, we remove the source package too, although we have nothing to replace it with.

I think we should keep the source package in the repo in that case.

mika commented 7 years ago

Good catch. We're talking about https://github.com/mika/jenkins-debian-glue/blob/master/scripts/build-and-provide-package#L780 - right?

laeti-tia commented 7 years ago

Yes, that's the line. I have a PR I should be able to propose shortly.

laeti-tia commented 7 years ago

Maybe there is a bit of redundancy when setting SKIP_SOURCE_REMOVAL but this is every place where the binary builds are being decided.