search

mika / jenkins-debian-glue

Scripts for Debian package/repository handling inside Jenkins
MIT License
131 stars 91 forks source link

cowbuilder (update) doesn't care about the $DIST variable but $DISTRIBUTION #211

Open nuxwin opened 5 years ago

nuxwin commented 5 years ago

Currently the build-and-provide-package script call cowbuilder as follows (update process)

sudo DIST="${distribution:-}" ARCH="${architecture:-}" ${ADT:+ADT=$ADT} \
 cowbuilder --update --basepath "${COWBUILDER_BASE}" --configfile="${pbuilderrc}"

This doesn't seem to be a problem but for consistency and less confusing for newbies, it could be great to pass the correct distribution to cowbuilder through the --distribution option (or DISTRIBUTION variable) because right now, it look like cowbuilder virtually fallback to sid distribution.

mika commented 5 years ago

Hm, this might actually be related to #183? Any chance you might check whether the PR/commit from @bmiklautz would fix this issue for you?