search

mika / jenkins-debian-glue

Scripts for Debian package/repository handling inside Jenkins
MIT License
131 stars 91 forks source link

autopkg_binary variable needs to always be set #215

Closed willdeberry closed 5 years ago

willdeberry commented 5 years ago

If you used ADT_OPTIONS, this would not allow autopkg_binary variable to be set thus running into an unbound variable error on line 591. This separates the concerns of the options being used and the actual binary being executed.

Also, adt-run and autopkgtest are not API compatible. For instance, adt-run expects --changes to point to the changes file whereas autopkgtest expects the changes file pass as a positional arg. This change takes that into consideration as well.

willdeberry commented 5 years ago

@mika Just wanted to flag this as this seems like a critical issue if a user provides ADT_OPTIONS as we did in our jobs.

mika commented 5 years ago

Thanks @willdeberry for raising this, I'm just very busy those days, will try to takle this within the next few days!

willdeberry commented 5 years ago

Completely understandable. I just am lucky to be able to contribute on behalf of work :)

mika commented 5 years ago

Thanks for contributing this, LGTM! Great work, just merged this!