Puppet improvements - Githubissues

mika / jenkins-debian-glue

Scripts for Debian package/repository handling inside Jenkins

MIT License

131 stars 91 forks source link

Puppet improvements #225

Closed CyrilBrulebois closed 5 years ago

CyrilBrulebois commented 5 years ago

Hi Mika,

You'll find a couple of small puppet improvements, a heavy simplification (factorizing the require on Package['jenkins']), and also a bugfix for Jenkins 2.176.2 regarding detached plugins.

Unfortunately, even with those patches, I'm getting some other issues due to plugin dependencies, that I'll document separately, in an issue.

Thanks for considering, Cyril, with his DEBAMAX hat.

CyrilBrulebois commented 5 years ago

If that's helpful, I can share logs from clean installations with:

nothing forced
only bouncycastle-api forced
both bouncycastle-api and junit forced

mika commented 5 years ago

Meh, really sorry that this took way longer than anticipated. :( But finally found time for it and once I fixed some further things with a) Debian/buster (gnupg not present) and b) git-client plugin dependency I could actually successfully test it. :)

Thanks a bunch for the PR and fixes, highly appreciated! :+1: