search

mika76 / mamesaver

Mamesaver is a mame emulated screensaver - get all the good ol' games playing their demo modes while you procrastinate and enjoy!
https://mika76.github.io/mamesaver/
MIT License
36 stars 10 forks source link

Layout options #16

Closed nullpainter closed 5 years ago

nullpainter commented 5 years ago

@andyvans was asking if there was an option to turn the titles off or change the font. Sounds like it could be a reasonable feature, particularly if you have some cool retro fonts.

So, perhaps another tab called 'layout' with:

  1. System font list, defaulted
  2. Font size, defaulted
  3. Titles on/off checkbox, defaulted to on
  4. Reset to defaults button

What do you think? We could also include a colour picker, but I'm not convinced that it'd add much value.

mika76 commented 5 years ago

I love it - sounds great - I was wondering though - do you think you could re-add the title screen as an option as well? I kinda like it 😊 and I think it's a nice Mame promotion...

nullpainter commented 5 years ago

Ha, sure! Can we compromise on the ten seconds though? It's an awfully long time to stare at a huge MAME logo 😆

mika76 commented 5 years ago

🤣 for sure - you could even make that an option if you're adding an options screen hah

mika76 commented 5 years ago

To make things easier - thinking of @andyvans idea - you could pop a property editor onto a tab and just have a whole bunch of settings in a class which gets serialized/deserialized. The options form might not have to be a big dev if you do that...

nullpainter commented 5 years ago

you could even make that an option if you're adding an options screen

Configuration for tinkerers, by tinkerers 😁

To make things easier - thinking of @andyvans idea - you could pop a property editor onto a tab and just have a whole bunch of settings in a class which gets serialized/deserialized

Yes, that could work. There would be different options for the 'classic' vs. in-game display though. I was initially thinking that changing the mode would show/hide form elements. I'll have a chat to Andy in the morning as he's had more experience in Windows UI than me.

Since you're keen on keeping the classic display available, would you prefer if I incorporated this into PR #15?

mika76 commented 5 years ago

I really don't mind - whatever is easier for you guys - you guys are on a roll 😊

nullpainter commented 5 years ago

Makes a pleasant change from banking!

mika76 commented 5 years ago

Funny, if I think back I was working at a Bank in South Africa when I first created this...

nullpainter commented 5 years ago

(comments about shifting away from registry deleted - I'll just tidy up the Settings.cs class a little)

mika76 commented 5 years ago

Hey if serializing/deserializing an xml file is easier go for it - I don't mind - only thing is updates - but I don't think too many people are using this anyway so it's not a big issue

nullpainter commented 5 years ago

All covered by PR #18, which is good to go. I have tested it and written tests for the configuration stores and layout builder, but it would probably warrant a bit more of a workout.