This PR renames the vague 'skip game validation' option to 'Include games with imperfect emulation' and tightens up the rules. The previous option skipped game status checks entirely with this enabled, however this inadvertently included BIOS ROMs and completely broken ROMs.
The behaviour now is for this option to include imperfect in addition to good for valid statuses and for status checks to always take place.
The PR also tweaks the logging slightly. The previous behaviour was to only log to the event log if there isn't any filesystem logging, This has been changed to always write to the Windows Event Log for error and warning logging.
mika76
commented
6 years ago
This PR renames the vague 'skip game validation' option to 'Include games with imperfect emulation' and tightens up the rules. The previous option skipped game status checks entirely with this enabled, however this inadvertently included BIOS ROMs and completely broken ROMs.
The behaviour now is for this option to include
imperfectin addition togoodfor valid statuses and for status checks to always take place.The PR also tweaks the logging slightly. The previous behaviour was to only log to the event log if there isn't any filesystem logging, This has been changed to always write to the Windows Event Log for error and warning logging.