search

mika76 / mamesaver

Mamesaver is a mame emulated screensaver - get all the good ol' games playing their demo modes while you procrastinate and enjoy!
https://mika76.github.io/mamesaver/
MIT License
37 stars 10 forks source link

Screensaver not always gracefully exiting #27

Closed nullpainter closed 6 years ago

nullpainter commented 6 years ago

Particularly when jiggling mouse before MAME, an unhandled exception is thrown. This appears to be a recent regression and the unhandled exception handling doesn't appear to be catching it.

Feel free to assign this to me.

nullpainter commented 6 years ago

Have been unable to replicate, but suspect it may have been due to us not waiting for the MAME process to terminate before the screensaver exits. I have fixed this and added a bunch of other small fixes. Will create a single PR for these, #25 and #26.

mika76 commented 6 years ago

Sweet 😊

mika76 commented 6 years ago

Heh I've been playing around with the github Project and Milestone stuff - really cool!