mika76 / mamesaver

Mamesaver is a mame emulated screensaver - get all the good ol' games playing their demo modes while you procrastinate and enjoy!
https://mika76.github.io/mamesaver/
MIT License
37 stars 10 forks source link

Filter mechanical games, improve BIOS identification #45

Closed nullpainter closed 5 years ago

nullpainter commented 6 years ago

As noted on arcadecontrols.com, mechanical games (i.e., fruit machines) shouldn't be included in the game list.

I suspect we are implicitly filtering these anyway as the majority appear to only be partially emulated, however there is an ismechanical attribute for mechanical games in the listxml output, so it makes sense to filter by this.

There are also isbios and isrunnable flags so we should also check for these rather than just rely on the emulation status. Adding these checks pared down my list of games slightly, so clearly our status check wasn't quite good enough.

mika76 commented 6 years ago

Good stuff - filtering the list is always good - it's so frustrating to run into the odd game that does not want to work in the screensaver...

nullpainter commented 5 years ago

Resolved by PR #49.