search

mika76 / mamesaver

Mamesaver is a mame emulated screensaver - get all the good ol' games playing their demo modes while you procrastinate and enjoy!
https://mika76.github.io/mamesaver/
MIT License
37 stars 10 forks source link

Feature/legacy mame #54

Open nullpainter opened 5 years ago

nullpainter commented 5 years ago

This branch resolves issues #52 and #53.

I have bumped the version to 3.0.1 and updated AssemblyInfo.cs. Check your Appveyor config, @mika76 - remember the previous version was still displaying as 2.0.0 when installed from the MSI.

nullpainter commented 5 years ago

@mika76 I see this inadvertently pulled in some ancient commits, one of which was adding Appveyor.yml. It looks pretty skeletal, which suggests that it may not have been tested or complete. Feel free to remove if it's causing issues.

mika76 commented 5 years ago

Hey @nullpainter the appveyor file, it would break our build again - could you remove it - It'll be faster since I'm not by the PC these days as much...

mika76 commented 5 years ago

hmm or maybe better yet - I exported the appveyor file from the appveyor build so we could place it with the source. Just replace the current one with this...

version: 1.0.{build}
image: Visual Studio 2017
configuration:
- Release
- Repack
platform: Any CPU
before_build:
- cmd: nuget restore
build:
  verbosity: minimal
artifacts:
- path: MamesaverDeploy\bin\Repack\Mamesaver.msi
  name: Mamesaver.msi
- path: Mamesaver\bin\Repack\Mamesaver.scr
  name: Mamesaver.scr
- path: Mamesaver\bin\Repack\*.dll
  name: dlls
- path: Mamesaver\bin\Repack\Mamesaver.exe
  name: repack exe
nullpainter commented 5 years ago

@mika76 done.

mika76 commented 5 years ago

Thanks Matt. So you're pretty confident about this change? Cuz I'm not sure I can test it really. Code seems good...

Also as per semver - you don't think this should be 3.1 instead of 3.0.1? It kinda feels like you added new functionality :smile:

nullpainter commented 5 years ago

I'm confident (I now have several different versions of MAME, and both rebuilt the game list and quickly tested using each), but it's always good to get a second pair of eyes. @andyvans, do you have capacity?

This is new functionality, but it was pretty minor. Happy be swayed by popular opinion though :)

nullpainter commented 5 years ago

Okay, it appears that confident != performant. Perhaps 2k ROMS is extreme, but I'm keen to try a fallback of your original approach first and see if that results in a better outcome.

mika76 commented 5 years ago

Hey @nullpainter not sure where we stand on this one? Merge or ignore?

nullpainter commented 5 years ago

There's no harm in merging, but we need to add sufficient caveats to the documentation, I think.

mika76 commented 5 years ago

So what would we have to add? Just the required minimum MAME version and also like a limit to the amount of roms?

nullpainter commented 5 years ago

Pretty much. Versions from 0.155 have been tested, but it's possible that earlier versions work. I guess note that any MAME version earlier than 0.191 may be less performant - particularly with large numbers of ROMs.