search

mikaa123 / linear

Ruler app with web-development in mind
http://mikaa123.github.io/linear-website/
MIT License
262 stars 21 forks source link

[bug] Duplicating a ruler with Black guides produces one with White guides #22

Open adamellsworth opened 8 years ago

mikaa123 commented 8 years ago

Thanks! Will look into it. We might ditch the dark theme in favor of the new light theme #21.

adamellsworth commented 8 years ago

You're a champ for this app; it's absolutely great!

Thank you for all your hard work.

:sunny:

radiovisual commented 8 years ago

This is technically still an issue even after the new custom theme features have been merged.

In order to let the duplicated ruler keep the style of the original ruler, we would either need to track the states of each ruler (where the state would include the ruler's theme), or we would have to figure out a way of sending the original ruler's theme to the duplicated ruler once it was created.

Each ruler has it's own updateTheme() method, so it could just be a matter of broadcasting the original ruler's theme to the duplicated ruler, which will update the duplicated ruler's theme.

radiovisual commented 8 years ago

In order to fix this, we have to figure out why electron's window.show() method is not firing. Someone offered some advice regarding the use of electron-connect, so I am leaving a reference to this theory here for discovery.

With the update to the latest Electron, perhaps we will see some different behaviors. I will take a look when I have more free time.