search

mikaa123 / linear

Ruler app with web-development in mind
http://mikaa123.github.io/linear-website/
MIT License
262 stars 21 forks source link

settings font-size not working. #29

Closed radiovisual closed 8 years ago

radiovisual commented 8 years ago

In the readme.md, it says:

Uses px or em values; set the default font-size to your convenience.

It's the "set the default font-size to your convenience" part that I am wondering about...

The settings menu has an option for setting the Font Size, but:

  1. The font-size option in the settings doesn't appear to do anything; and
  2. The font-sized entered into the settings window isn't saved into the settings.json file, and
  3. The font-size entered into the settings window is not reloaded or remembered after the settings window is closed and reopened.

So should this feature be removed, and we can let the the users override the font size in their own custom theme(s)?

mikaa123 commented 8 years ago

I think the font-size setting is kind of a misnomer. It's not the actual size of the font in the application, but it's the base value used to calculate the em. For this reason, I don't think it would be possible to override the font-size in the theme.

Thanks for reporting this though, I'll check to see why it's not working correctly.

radiovisual commented 8 years ago

Oh, I see. I misunderstood the true purpose of the font-size setting. No problem.