mikabytes / gearbox

8 stars 0 forks source link

rate-limiter doesn't trust proxy #22

Closed mikabytes closed 4 months ago

mikabytes commented 4 months ago

One user reported seeing these logs when adding a new torrent. We should probably switch on 'trust proxy'

ValidationError: The 'X-Forwarded-For' header is set but the Express 'trust proxy' setting is false (default). This could indicate a misconfiguration which would prevent express-rate-limit from accurately identifying users. See https://express-rate-limit.github.io/ERR_ERL_UNEXPECTED_X_FORWARDED_FOR/ for more information.
    at Object.xForwardedForHeader (file:///app/node_modules/express-rate-limit/dist/index.mjs:138:13)
    at wrappedValidations.<computed> [as xForwardedForHeader] (file:///app/node_modules/express-rate-limit/dist/index.mjs:310:22)
    at Object.keyGenerator (file:///app/node_modules/express-rate-limit/dist/index.mjs:565:20)
    at file:///app/node_modules/express-rate-limit/dist/index.mjs:616:32
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///app/node_modules/express-rate-limit/dist/index.mjs:597:5 {
  code: 'ERR_ERL_UNEXPECTED_X_FORWARDED_FOR',
  help: 'https://express-rate-limit.github.io/ERR_ERL_UNEXPECTED_X_FORWARDED_FOR/'