mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2023. Beginners are welcome!
https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/
Apache License 2.0
214 stars 123 forks source link

IMPROVE - Update the design of MaitenanceEvent list element in DashboardView #174 #254

Closed mitaligondaliya closed 10 months ago

mitaligondaliya commented 10 months ago

What it Does

How I Tested

For example:

Screenshot

Simulator Screenshot - iPhone 15 Plus - 2023-10-31 at 00 29 04

mitaligondaliya commented 10 months ago

@mikaelacaron You were saying to add the event formatter inside the body? I tried but inside the body we can't assign the dates style So, I kept it as private computed property there.

mikaelacaron commented 10 months ago

@mikaelacaron You were saying to add the event formatter inside the body? I tried but inside the body we can't assign the dates style So, I kept it as private computed property there.

No I mean like this way, from this article, sorry my other comment looks like I never linked it properly

You put the formatter parameter inside the string interpolation, as opposed to using the string function that's on the formatter like you did here:

eventDateFormatter.string(from: event.date)

mitaligondaliya commented 10 months ago
Screenshot 2023-10-31 at 10 37 46 AM

Swipe action Edit word is there not disappeared.

mitaligondaliya commented 10 months ago

@mikaelacaron I've pushed the changes please review it and let me know if there is anything need to change.

mitaligondaliya commented 10 months ago

@mikaelacaron This one is showing not accepted in hacktoberfest, Could you please mark it as hacktoberfest-accepted?

mikaelacaron commented 10 months ago

It was merged so it should show as accepted, sometimes it takes a minute, but I did mark it as that too

mitaligondaliya commented 10 months ago

It was merged so it should show as accepted, sometimes it takes a minute, but I did mark it as that too

Okay Thanks 👍🏼 @mikaelacaron