mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2023. Beginners are welcome!

https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/

Apache License 2.0

214 stars 123 forks source link

added date picker and color picker :) #275

Closed AballahNsour closed 9 months ago

AballahNsour commented 9 months ago

I still need to figure out how to convert a cgcolor value then persist that into the data base

What it Does

Closes #issueNumber
Describe what your change does

How I Tested

Add a list of steps to show the functionality of your feature For example:
Run the application
Tap the (+) button
See this screen etc...

Notes

Anything else that should be noted about how you implemented this feature?

Screenshot

Add a screenshot of your new feature! OR show a screen recording of it in action. (On the simulator press Cmd + R to record, and the stop button when done). This video should be no longer than 30 seconds.

mikaelacaron commented 9 months ago

Thank you for wanting to contribute!

Your PR isn't linked to an issue. Before contributing to my repo, please always make sure it's connected to the issue

Also your PR doesn't describe what's changed and why (which could've been explained in the issue)

Also the DatePickerView is just HelloWorld, so this feature isn't finished yet (meaning it's not ready for a PR)

AballahNsour commented 9 months ago

sorry for that I will correct my work, I am a beginner. I will continue to contribute :)

mikaelacaron commented 9 months ago

Please make an issue and describe if you are wanting to do like make a new feature, an improvement, or report a bug. (what you've done so far would be an improvement) Follow the issue template.

I'm going to close this PR because it is not complete, and you didn't fill out the PR template, which is required.

My repo is beginner friendly, and please read the README and CONTRIBUTING rules so you know how to contribute to the project.