mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2023. Beginners are welcome!
https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/
Apache License 2.0
214 stars 123 forks source link

feature: Use NavigationSplitView rather than TabView for iPad #6 #279

Closed windrunner21 closed 2 months ago

windrunner21 commented 8 months ago

What it Does

How I Tested

Notes

Screenshot

https://github.com/mikaelacaron/Basic-Car-Maintenance/assets/18750749/7eda95ac-3913-426c-b3a7-eb210ba943b9

https://github.com/mikaelacaron/Basic-Car-Maintenance/assets/18750749/d78bad15-0f16-486e-bf8c-3a3612f3d982

windrunner21 commented 8 months ago

@mikaelacaron hi, hope all is well 😄 did you have the chance to look at the PR?

mikaelacaron commented 8 months ago

@windrunner21 No I haven't, and it's the holidays so I'm not going to be looking at this today. You'll see my review when I have time

windrunner21 commented 8 months ago

@mikaelacaron oh sorry, you are right, I totally forgot about it. Merry Christmas! Have a great holiday 🥳

windrunner21 commented 8 months ago

hey @mikaelacaron, sorry for the late reply, still on holidays! I'll update PR with requested changes by Sunday latest.

mikaelacaron commented 8 months ago

@windrunner21 No worries at all! Take vacation! 👍

mikaelacaron commented 8 months ago

@windrunner21 After you address all the comments, please click the re-review button

Re-review button

Also if you fix something I mentioned and don't have any questions, go ahead and click the Resolve button, but if you have a question, you can comment on that question directly

windrunner21 commented 8 months ago

@mikaelacaron I didn't click it yet because I still have to solve the bug with reopening the same tab after relaunching application. I wanted to solve everything and then request review 😄

mikaelacaron commented 8 months ago

Yup! You should resolve everything for sure! I just mentioned this cause I got notified you were working on it haha

And I saw that I didn't mention it in my first review

windrunner21 commented 8 months ago

@mikaelacaron just finished with the bug fix, implemented it in such a way that TabView / NavigationSplitView are having the same last opened tab.

mikaelacaron commented 2 months ago

@windrunner21 thanks for working on this! haha just now finally getting around to finishing up the final bits of this project to launch it