mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2023. Beginners are welcome!
https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/
Apache License 2.0
214 stars 123 forks source link

BUG - Default language issue #281

Closed rbennum closed 8 months ago

rbennum commented 8 months ago

Describe the bug

After the last PR merged, the default language changed to Polish.

To Reproduce

Steps to reproduce the behavior:

  1. Build and open the app.

Expected behavior

I expect the app's default language to be English.

Screenshots

photo_2024-01-01_20-49-50

maartinj commented 8 months ago

Option+Command+R when launching simulator, change 'App Language' to 'System Language' and 'App Region' to 'System Region' will not work here?

Zrzut ekranu 2024-01-3 o 02 05 44
rbennum commented 8 months ago

@maartinj hi, thank you for replying to my concern. I think what you showed me should work. The problem perhaps lies when you also pushed the changes on xcschemes here. Removing this should solve the problem.

maartinj commented 8 months ago

Hi @rbennum,

Oh apologize for that. Seems that I left during Option+Command+R when launching simulator, with 'Polish' language in 'App Language' instead of 'System Language'.

I will request new PR to @mikaelacaron for checkout and to merge fix to the dev branch.

Thank you for vigilance and apologize for the confusion.

rbennum commented 8 months ago

@maartinj glad to help!

mikaelacaron commented 8 months ago

All good @maartinj ! it happens, haha I didn't notice either

mikaelacaron commented 8 months ago

@rbennum Thanks for reporting it!

rbennum commented 8 months ago

@mikaelacaron you're welcome!