mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2023. Beginners are welcome!
https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/
Apache License 2.0
220 stars 130 forks source link

FEATURE - Medium Widgets, View Maintenance Events #50

Open mikaelacaron opened 1 year ago

mikaelacaron commented 1 year ago

Describe the feature you want the app to have that it currently doesn't

Describe alternatives you've considered

N/A

Additional context

Only make the medium widget (I'll create new issues for adding different widget sizes later

mikaelacaron commented 1 year ago

@harryheres wanted to work on this, can you comment on this and I'll assign it to you

HarryHeres commented 1 year ago

@mikaelacaron Yes, Iā€™m done with the #7 for now, so I can work on this :)

mikaelacaron commented 1 year ago

Notice on dev I created the Widget extension now, to hopefully cut down on merge conflicts

HarryHeres commented 1 year ago

Oh okay, thank you for the update!

mikaelacaron commented 1 year ago

Sorry! This task isn't ready to be worked on right now, because I haven't connected the models together, feel free to choose another issue and I'll leave you as an assignee and let you know when you can come back to work on this issue

HarryHeres commented 1 year ago

Okay, will stop working for the time being. Will be happy to continue once you've done the necessary features. Also, what models in particular are you referring to? Might be able to help out?

mikaelacaron commented 1 year ago

MaintenanceEvent and Vehhicle aren't connected, I would, but it might require how I am passing the models around, also I still need to change some Firebase rules

HarryHeres commented 11 months ago

@mikaelacaron How are we doing with this?

mikaelacaron commented 11 months ago

Once #141 is done, you're ready! Thanks for your patience! I was going to do it myself, but kinda got caught up, so I created an issue for someone else to work on this

HarryHeres commented 11 months ago

Once #141 is done, you're ready! Thanks for your patience! I was going to do it myself, but kinda got caught up, so I created an issue for someone else to work on this

Awesome, will be looking forward to it!

mikaelacaron commented 11 months ago

This can be worked on now! Thanks so much for the patience

HarryHeres commented 11 months ago

Awesome, will get to it ASAP!

HarryHeres commented 11 months ago

@mikaelacaron Do you want me to create new separate class for the medium widget or just modify the sample BasicCarMaintenanceWidget source file?

Also, the widgets as provided at the moment, appear blank. I checked the code and it seems to me that it should be filled with couple of Simple Entries, each an hour apart (or a single entry as a placeholder). Or is there something I'm missing?

image

UPDATE: When migrated to StaticConfiguration and TimelineProvider, the widgets show their contents. Seems like a bug inside the WidgetKit. Any ideas if there's a solution to this?

mikaelacaron commented 11 months ago

UPDATE: When migrated to StaticConfiguration and TimelineProvider, the widgets show their contents. Seems like a bug inside the WidgetKit. Any ideas if there's a solution to this?

I'm not sure, it worked by default with the current code on my machine.

And yes go ahead and make a new class for the size

HarryHeres commented 11 months ago

Have you tested in on a real device or in a simulator?

mikaelacaron commented 11 months ago

Both, for the default widget, they work for me

HarryHeres commented 11 months ago

Hmm, okay, will try to inspect a bit more then.

mikaelacaron commented 11 months ago

Unfortunately I think I'm going to need to put this on hold again, because it's not going to filter properly, by vehicle, the way it's being saved right now

I thought it was, but looking at it closer I don't think it is

HarryHeres commented 11 months ago

Okay, let me know when it gets resolved :)

mikaelacaron commented 11 months ago

Sorry šŸ˜… I just noticed it last night, will post more soon

HarryHeres commented 11 months ago

Sorry šŸ˜… I just noticed it last night, will post more soon

No worries, take your time :)

mikaelacaron commented 11 months ago

Thanks for your patience! I'm going to hold off on all the widget tasks for right now because I'm going to change how the vehicles and maintenance events are connected. But because it's so close to the end of Hacktoberfest I don't want to break everything for everyone, so I'll open this issue again after Hacktoberfest and you're welcome to contribute to it for fun if you'd like

mikaelacaron commented 4 days ago

Opening this back up for Hacktoberfest 2024!

aking618 commented 9 hours ago

@mikaelacaron Can I work on this? It'll be fun trying out working with widgets.

mikaelacaron commented 9 hours ago

@aking618 you got this! šŸ”„