mikaelacaron / Basic-Car-Maintenance

A basic app to track your car's maintenance. Open source for Hacktoberfest 2024. Beginners are welcome!
https://mikaelacaron.github.io/Basic-Car-Maintenance/documentation/basic_car_maintenance/
Apache License 2.0
242 stars 145 forks source link

IMPROVE - Voice Over / Voice Control Accessibility for `DashboardView` #51

Closed mikaelacaron closed 10 months ago

mikaelacaron commented 1 year ago

Describe the feature you want to improve

Describe alternatives you've considered

mikaelacaron commented 1 year ago

@montanabraswell said she was interested in this one, please comment below so I can officially assign you to this issue

narendrajagne commented 1 year ago

Hi, Can you please assign me this issue ?

montanabraswell commented 1 year ago

Hi, sorry just saw this now, if this is still available I’d like to take it. :)

mikaelacaron commented 1 year ago

I am assigning this to @montanabraswell Like I mentioned in my first comment. @narendrajagne Please find a different issue to work on

narendrajagne commented 1 year ago

ok

mikaelacaron commented 1 year ago

@montanabraswell Are you planning on updating this in the next few days? Hacktoberfest ends in about 1 week, for it to count as a PR, it needs to be merged or accepted by the 31st.

If you're not interested in updating this let me know, or remove yourself as an assignee on the issue, thank you!

montanabraswell commented 1 year ago

Hi Mikaela,

Yes! Thanks for the response - I'm working on it today. Sorry, work has been a bit crazy the last few weeks. Thanks for your patience!

On Tue, Oct 24, 2023 at 1:49 AM Mikaela Caron @.***> wrote:

@montanabraswell https://github.com/montanabraswell Are you planning on updating this in the next few days? Hacktoberfest ends in about 1 week, for it to count as a PR, it needs to be merged or accepted by the 31st.

If you're not interested in updating this let me know, or remove yourself as an assignee on the issue, thank you!

— Reply to this email directly, view it on GitHub https://github.com/mikaelacaron/Basic-Car-Maintenance/issues/51#issuecomment-1776573863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3AFOLOUFWYTEKNFSSOTXDYA5JGVAVCNFSM6AAAAAA5QQNSFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGU3TGOBWGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Montana Braswell Certified SAFe 4 Scrum Master [image: Certified SAFe® 4 Scrum Master]

yashlangaliya commented 1 year ago

@mikaelacaron Can I take this ticket?

rbennum commented 11 months ago

@mikaelacaron Hi! For my first time utilizing the voice-over feature, I want to propose a solution for this ticket: I will add the .accessibilityLabel functionality to every Text/Link I see in both DashboardView and SettingsView, so the voice-over feature can be as clear as possible. What do you think?

mikaelacaron commented 11 months ago

@rbennum I think that's a good start! Are there other things that we should do to have better Voice Over and Voice Control support?

rbennum commented 11 months ago

@mikaelacaron in case of Voice Control support, I suppose we can assign every link/button to the action name to be recognized by the voice control system. But with my current capability (I have never tried using and developing voice control), I think the scope is quite big so I want to separate it into each of their own, if that's okay with you.

mikaelacaron commented 11 months ago

When this ticket was originally written, the app was smaller. How about you do full Voice Over and Voice Control support only for the DashboardView and that's it

@rbennum

rbennum commented 11 months ago

@mikaelacaron I think I can manage that.

mikaelacaron commented 11 months ago

Great! Assigned you this issue!