BUG - Invalid API access from background thread

mikaelacaron / brain-marks

[Not Active] Open-source iOS app to save and categorize tweets

MIT License

80 stars 47 forks source link

BUG - Invalid API access from background thread #171

Closed DominatorVbN closed 2 years ago

DominatorVbN commented 2 years ago

Describe the bug

Codebase contains multiple invalid API access code paths either publishing or accessing unsupported API from background threads

To Reproduce

Steps to reproduce the behavior:

Go to 'Create category
Add a new category
Repeat above steep for 5-10 time
See error in the Xcode console

Expected behavior

There should be no invalid access occurring, this could lead to unpredicted behaviors in app

Screenshots

Device Info (please complete the following information):

Device: [iPhone14 Pro Simulato]
OS: [ iOS 16.1]
App Version [v1.1]

MikesHorcrux commented 2 years ago

Ill take a look at this bug and see if I can fix/ reproduce

MikesHorcrux commented 2 years ago

@mikaelacaron I keep getting

2022-10-29 11:55:19.613688-0500 brain-marks[21129:2679872] [Networking] ❌ Status code is 401

when trying to save a tweet I have my twitter api key in my secrets and still no go. am I missing something ?

MikesHorcrux commented 2 years ago

was able to reproduce this error but not with creating a category, this errors stems from the contribution view.

screen shot below Screenshot 2022-10-29 at 5 18 25 PM

mikaelacaron commented 2 years ago

@DominatorVbN I also only got this error on the SettingsView with the list of contributors, not when creating a new category Are you able to take a screen recording of you reproducing this?

mikaelacaron commented 2 years ago

Closed with #177