search

mikaelacaron / brain-marks

[Not Active] Open-source iOS app to save and categorize tweets
MIT License
80 stars 47 forks source link

FEATURE - Move Tweet to Different Category #66

Open mikaelacaron opened 3 years ago

mikaelacaron commented 3 years ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

kiennguyenchi commented 3 years ago

Hi, I'm new to Swift and interested to work on this issue. Could you please assign it to me? Thank you!

mikaelacaron commented 3 years ago

You got this! Let me know if you have any issues or questions getting set up!

kiennguyenchi commented 3 years ago

I created Twitter developer account, apply for Twitter API but I not sure what to do next to pull the Twitter API into the project?

mikaelacaron commented 3 years ago

Look at the Setting Up Secrets section of the CONTRIBUTING.md. You'll create your own file named Secrets.swift and add that to the project, make sure you don't commit this new file, it'll be ignored by git, but make sure it doesn't get added to the Xcode project file.

You'll paste your API key as the bearer token, like the example says, and that's it! Your project will be using your own API key to make network requests.

kiennguyenchi commented 3 years ago

I want to ask that how the leading swipe action will work in this situation? We swipe the URL box and then it leads to category page right? Screen Shot 2021-10-19 at 9 59 14 PM

mikaelacaron commented 3 years ago

The screen you're showing is the AddURLView which wouldn't be right because technically the user could change the tweet url, when they should only have access to change the category. I had originally based the UI from the Apple Notes application.

You can take inspiration from that, showing a new sheet of the different categories and then selecting one. Also note this issue does NOT cover having cascading / nested categories, that's too complicated for now

kiennguyenchi commented 3 years ago

I have 2 issues: 1/ I try to add an URL Tweets for testing but it shows invalid all the times. Screen Shot 2021-10-21 at 5 02 44 PM

2/ The preview of Tweet Card cannot show on XCode. Screen Shot 2021-10-21 at 5 04 04 PM

Please give me some advices, Thank You!

mikaelacaron commented 3 years ago

@kiennguyenchi you're using a tweet when you click the share button on Twitter right?

Like click share and then copy link and paste that link into the app? (It also should automatically grab your clipboard)

kiennguyenchi commented 3 years ago

Sorry, but can you please assign this question to another person? because my xcode cannot load the view of Tweet Card, so I cannot work on it.

mikaelacaron commented 3 years ago

Yup! Feel free to work on a different issue, if you'd like

marlonjames71 commented 2 years ago

@mikaelacaron So I've been trying to implement this, but there's an issue. As soon as you add swipeActions whether leading or trailing, it cancels out any onDelete modifier which has the nice delete animation. I'm reading that you're left with trying to implement your own delete animation, but Lists don't really play nicely with that.

A solution that might be nice is turning the tweets List into a LazyVStack and adding a context menu that has things like delete, move, etc.

mikaelacaron commented 2 years ago

That's interesting, and sure! Go ahead and try that

marlonjames71 commented 2 years ago

Was able to retain the swipe features. The delete animation isn't the same as you get out of the box from Apple, but it's still pretty nice. Not sure why I was having an issue before. Anyway, PR is up for this issue.