search

mikaelbr / node-notifier

A Node.js module for sending notifications on native Mac, Windows and Linux (or Growl as fallback)
MIT License
5.73k stars 322 forks source link

Fix hang on Disabled Windows 10 Notifications #335

Closed JasonGore closed 4 years ago

JasonGore commented 4 years ago

Fix named pipe server hang when notifications are disabled in Windows 10.

This PR can't address root cause (due to snoretoast's behavior) but at least resolves the hanging issue. I think it's important to fix with some kind of change at least temporarily to prevent a permanent hang in certain use cases. (More info in #334.)

Fixes #334.

JasonGore commented 4 years ago

The prettier pre-commit hook lint rules are at odds with the npm run lint configuration.

JasonGore commented 4 years ago

I had to use git commit --no-verify to fix the lint issues.

JasonGore commented 4 years ago

@mikaelbr Do you think there's any chance this fix will get merged? I want to deploy node-notifier but I can't since it will hang for some of our users. Thanks!

mikaelbr commented 4 years ago

Thanks for this! Merging now

JasonGore commented 4 years ago

@mikaelbr Thanks for merging! Do you know when the next release will occur?

mikaelbr commented 4 years ago

Right about now!

+ node-notifier@7.0.2

Get it while it's fresh! 🍣