search

mikaeljorhult / brackets-todo

Brackets/Edge Code extension that displays all TODO comments in current document or project.
144 stars 37 forks source link

Tags should be reloaded with new settings #45

Closed mikaeljorhult closed 10 years ago

mikaeljorhult commented 10 years ago

The array of tags should be rebuilt every time new settings are loaded, even if there are tags saved in preferences, as this can change the available tags.

anzhihun commented 10 years ago

Yes, I also find the bug. To fix it, another way is only adding new tag to visible tags in preference, not rebuilting. Which could not change the state of the tags which are not deleted by new settings.

mikaeljorhult commented 10 years ago

It might be cheaper to remember which tags are visible or not and then rebuild the array but I'm going to do some performance testing to see if that's the case before deciding.

mikaeljorhult commented 10 years ago

Let's just rebuild it every time, for now. We can improve on it later. (SHA: 3f11a89918ff1e50854222abebe2ae2e2833f62d)