search

mikaello / norwegian-national-id-validator

Validate Norwegian national identity numbers
https://mikaello.github.io/norwegian-national-id-validator
MIT License
24 stars 7 forks source link

Validation fails if user has a weird timezone #17

Closed svnv closed 4 years ago

svnv commented 4 years ago

In getBirthDate() a date is created with https://github.com/mikaello/norwegian-national-id-validator/blob/18d01f35567dd40ec13b52de98724d8cd20c92ed/src/index.ts#L131-L133

This will cause validation of date to fail if the end user has a non expected timezone in https://github.com/mikaello/norwegian-national-id-validator/blob/18d01f35567dd40ec13b52de98724d8cd20c92ed/src/index.ts#L18-L30

Example from console log in my IE11 virtual machine Screenshot 2019-10-31 at 10 35 33

mikaello commented 4 years ago

I see. So appending T00:00:00 could solve it? Alternatively use UTC new Date(Date.UTC(isoStr))?

svnv commented 4 years ago

yes, i have a PR ready in a few minutes