search

mikaelsundell / dctl

A continuously updated collection of DCTLs (DaVinci Color Transform Language) designed to enhance and educate on workflows using ARRI LogC3 and Cineon in DaVinci Resolve. This collection offers a photographic and creative approach to color correction and grading from log digital and film negatives.
https://github.com/mikaelsundell/dctl
13 stars 1 forks source link

Error in MS-Utils.h #2

Closed 333csx closed 1 month ago

333csx commented 1 month ago

Line 137:

return max(rgb, 0.0f);;

AFAIK you can't compare a float3 with a float.

use sth. like this :

DEVICE float3 adjust_display(float3 rgb) { rgb.x = _fmaxf(rgb.x, 0.0f); rgb.y = _fmaxf(rgb.y, 0.0f); rgb.z = _fmaxf(rgb.z, 0.0f);

return rgb;;

}

mikaelsundell commented 1 month ago

Thanks for reporting, will push a new update on Monday including better support for non-mac platforms.

mikaelsundell commented 1 month ago

@333csx Should now be fixed and DCTLs confirmed to run on Davinci Resolve 18.6/ Windows.