mikaelvesavuori / figmagic

Figmagic is the missing piece between DevOps and design: Generate design tokens, export graphics, and extract design token-driven React components from your Figma documents.
https://docs.figmagic.com
MIT License
807 stars 71 forks source link

Shadows missing Y value #154

Closed alehar9320 closed 2 years ago

alehar9320 commented 2 years ago

Describe the bug Shadows exported using Figmagic are missing Y value

To Reproduce Steps to reproduce the behavior:

  1. Make a copy of Figmagic's Figma example file
  2. Add a square object to shadows frame
  3. Add a drop-shadow effect to sqaure object, with value for both X, Y, Blur and Color
  4. Make Figmagic fetch from the duplicate of the Figma example file
  5. Notice that X, Blur and Color value is retrieved correctly. Y value is not.

Expected behavior All values should be present (X, Y, Blur and Color), as can be found in the local figmagic/figma.json file.

Screenshots

figma.json (input from Figma) image

shadows.ts (output) image

Desktop:

Additional context TBD

mikaelvesavuori commented 2 years ago

This does not seem to entirely true, see

shadows[NAME] += `${X} ${Y} ${RADIUS} rgba(${R}, ${G}, ${B}, ${A})`;

However I indeed see that X value was set on the Y output. Fixing.

mikaelvesavuori commented 2 years ago

This is now fixed in 4.4.2. Thanks for reporting!

kovavka commented 2 years ago

Hi @mikaelvesavuori! I faced the same problem and found this. Could you please fix it?

mikaelvesavuori commented 2 years ago

Hey @kovavka! Seems this was a slip-up on my side. I just did a quick adjustment that should address this, released in 4.4.5.

kovavka commented 2 years ago

Thank you so much, it works now. Your project have a best support I've ever seen!