Closed mitchdotdeveloper closed 1 year ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Looking good @mitchdotdeveloper! Great work and happy to merge this in.
I will add your name to the list of contributors too and push this to a new release ASAP.
Please find your additions now released in 4.5.5
at https://github.com/mikaelvesavuori/figmagic/releases/tag/v4.5.5
Thanks for contributing!
Hey Mikael!
I am currently using figmagic at work, awesome project btw, as we build out our design system and thought this might be a worthwhile addition.
In this PR I added the units
s
andms
, seconds and milliseconds respectively, to theduration
token. In our use we found we were having to appends
to all of our duration tokens which is somewhat cumbersome.Currently I have duration units defaulting to
s
, however I'm curious if you think it would be useful to have the duration units as an "opt-in" unit? Some cases like CSS will requires
orms
however these could also be used in JS withsetTimeout
for example which does not have units attached and expects milliseconds.