search

mikaem / Oasis

55 stars 48 forks source link

Remove Python 2 support #22

Closed benzwick closed 5 years ago

benzwick commented 5 years ago

I could not run Oasis inside a container because:

ImportError: No module named six

Python 2 support was removed from FEniCS since 2018.1.0 and FEniCS docker images no longer include python-six. Since FEniCS no longer supports Python 2 we can also remove it from Oasis.

mikaem commented 5 years ago

Do you want me to add you as collaborator @benzwick ? So you don't have to create a PR for every typo you find:-) I'm currently more involved in the spectralDNS project and it would be great if someone like yourselves, that is using Oasis with current Fenics version, could help make sure the code is up to date.

benzwick commented 5 years ago

That would be great @mikaem

Most of the examples now run with FEniCS 2018.1.0 but there are still some with errors and some that don't run with MPI. Should I create issues to document these?

mikaem commented 5 years ago

Yes, please create some issues of remaining errors.