mikaem / Oasis

55 stars 48 forks source link

Wale model: common.py "user_sub_domain" and DirichletBC "markers()" #41

Open JoelTomasek opened 3 years ago

JoelTomasek commented 3 years ago

Dear Sir,

When trying to use the 'Wale' model, I received the following error: AttributeError: 'DirichletBC' object has no attribute 'user_sub_domain'.

Having changed 'user_sub_domain' to user_subdomain (compatible with dolfin 2018), this error is resolved.

Then the following error occurs: "/home/ubuntu/anaconda3/envs/oasis/lib/python3.7/site-packages/oasis-2018.1-py3.7.egg/oasis/solvers/NSfracStep/LES/common.py", line 21, in derived_bcs m = bc.markers() # Get facet indices of boundary AttributeError: 'DirichletBC' object has no attribute 'markers'

In the following link it is stated that in python version of dolfin 2018.1 the markers() attribute is indeed missing. https://bitbucket.org/fenics-project/dolfin/issues/1042/python-interface-for-dirichletbcmarkers

Is there some other way to get facet indices of the boundary within the " derived_bcs" function in oasis.solvers.NSfracStep.LES.common, to make this function compatible with dolfin 2018.1?

With kind regards, Joel