search

mikakoivisto / controlmyspa-ha-mqtt

GNU General Public License v3.0
11 stars 4 forks source link

temp.step change to 1? #3

Closed JSkier21 closed 2 years ago

JSkier21 commented 2 years ago

Greetings,

Throwing this out there for discussion before a PR, I noticed that with temp being 0.5, HA struggles sometimes submitting a new temperature if at .5 decimal (NaN error). Side note, it seems MQTT is reporting the temp without decimal.

Not sure how this tub works in Celsius land, although I could test that out in a few weeks. Would removing the decimal create any headaches or drawbacks, settings temp.step to 1?

Picture of climate card: image

JSkier21 commented 2 years ago

Did some more playing around with this, I think this is more of a problem with the rate limiting on this thing 😥 Closing this.

mikakoivisto commented 2 years ago

There's some unstability in the current implementation due to lack of error handling. I have improvements coming.