search

mikaku / Fiwix

A UNIX-like kernel for the i386 architecture
https://www.fiwix.org
Other
401 stars 32 forks source link

Implement readv and writev system calls. #43

Closed rick-masters closed 9 months ago

rick-masters commented 9 months ago

Closes #42

mikaku commented 9 months ago

Hi @rick-masters (and welcome back!),

I'll give it a try! In the meantime, and please, consider change the copyright lines to include your name since you are author of that code.

rick-masters commented 9 months ago

The new files were initially copied from the implementations of read and write so that's why they have your copyright on them. I can add another copyright for my changes. I'll wait a bit to see if you have any other feedback.

mikaku commented 9 months ago

Your code looks good to me.

As Open Group says, perhaps we should include the constant UIO_MAXIOV with an initial value of 16 (as stated in IEEE Std 1003.1, 2004 Edition).

We can do it later, of course.

mikaku commented 9 months ago

As soon as you include the copyright adjustment I'll merge this PR.

mikaku commented 9 months ago

Thank you.