search

mikaku / Fiwix

A UNIX-like kernel for the i386 architecture
https://www.fiwix.org
Other
401 stars 32 forks source link

Implement mmap2 system call. #48

Closed rick-masters closed 9 months ago

rick-masters commented 9 months ago

Closes #47

mikaku commented 9 months ago

I'd enclose the file kernel/syscalls/mmap2 with a #define CONFIG_SYSCALL_6TH_ARG starting right before the line 21, basically because it is no so evident that someone will also need that option to make sys_mmap2() work.

I mean, the rest of kernel options are (or should be) working without knowing any kind of dependency that is not visible in the same source file.

rick-masters commented 9 months ago

I'd enclose the file kernel/syscalls/mmap2 with a #define CONFIG_SYSCALL_6TH_ARG starting right before the line 21

Do you mean #ifdef CONFIG_SYSCALL_6TH_ARG ?

mikaku commented 9 months ago

Do you mean #ifdef CONFIG_SYSCALL_6TH_ARG ?

Oh yes, sorry.

mikaku commented 9 months ago

@rick-masters Let me remind you that I plan to do a code freeze in two days because I need some time to prepare the build of the new FiwixOS 3.3 that will include the Fiwix version 1.5.0.

So if you still have some pending ports, please choose the smaller ones and leave the bigger ones for later.

rick-masters commented 9 months ago

@rick-masters Let me remind you that I plan to do a code freeze in two days because I need some time to prepare the build of the new FiwixOS 3.3 that will include the Fiwix version 1.5.0.

So if you still have some pending ports, please choose the smaller ones and leave the bigger ones for later.

OK I can hold off changes until after the release.

mikaku commented 9 months ago

OK I can hold off changes until after the release.

That's perfect. The release should be publicly available on 15 November.

Thank you.