mikaku / Fiwix

A UNIX-like kernel for the i386 architecture
https://www.fiwix.org
Other
401 stars 32 forks source link

Implement stub for syscall madvise which always returns success. #56

Closed rick-masters closed 7 months ago

rick-masters commented 7 months ago

Resolves #55

mikaku commented 7 months ago

Some fixes needed:

  1. I'd change CONFIG_XXXXXX_STUB by CONFIG_STUB_XXXXXX, this way a simpler grep CONFIG_STUB will return the list of stub-related options.
  2. In unistd.h you can remove the blank line between SYS_madvise and SYS_getdents64 since they have consecutive system call numbers.
  3. In madvise.c you can remove me as a copyright holder since the code is 100% yours.
  4. Also in madvise.c you forgot to include the common debug code.
rick-masters commented 7 months ago

Closing due to implementing a workaround in musl instead.