mikal-k / moji-the-decoder

0 stars 0 forks source link

Sweep: The URL should reflect the emoji shown #11

Closed mikal-k closed 8 months ago

mikal-k commented 8 months ago

The purpose of the site is primarily to visualize 200D ZWJ emojis, and letting the URL reflect emoji(s) also makes it possible to link to the site.

Checklist - [X] ``moji.js`` ✅ Commit 0fb714a - [X] `moji.js` ✅ Sandbox ran successfully - [X] `moji.js` ✅ Sandbox ran successfully - [X] `moji.js` ❌ Sandbox failed so I made additional changes - [X] ``public_html/index.html`` ✅ Commit 9c7b939 - [X] `public_html/index.html` ✅ Sandbox ran successfully - [X] ``docker-compose.yml`` ✅ Commit d46ff56 - [X] `docker-compose.yml` ✅ Sandbox ran successfully - [X] `docker-compose.yml` ✅ Sandbox ran successfully - [X] `docker-compose.yml` ❌ Sandbox failed so I made additional changes - [X] ``package.json`` ⚠️ No Changes Made - [X] `package.json` ❌ Sandbox failed so I made additional changes - [X] `package.json` ❌ Sandbox failed so I made additional changes ![Flowchart](http://24.199.78.105:8082/public/fb4f048de3e9cc3d88ef09986fb7191102053ab5ff5716a87e8e551241a426e0_11_flowchart.svg)
sweep-ai[bot] commented 8 months ago

Here's the PR! https://github.com/mikal-k/moji-the-decoder/pull/13.

⚡ Sweep Basic Tier: I'm creating this ticket using GPT-4. You have 5 GPT-4 tickets left for the month and 3 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/mikal-k/moji-the-decoder/blob/3ecffe3ee92ada8d66ce8f44505ab612f2c45b70/README.md#L1-L19 https://github.com/mikal-k/moji-the-decoder/blob/3ecffe3ee92ada8d66ce8f44505ab612f2c45b70/docker-compose.yml#L1-L14 https://github.com/mikal-k/moji-the-decoder/blob/3ecffe3ee92ada8d66ce8f44505ab612f2c45b70/package.json#L1-L39

Step 2: ⌨️ Coding


Sandbox logs for f00817a
trunk fmt moji.js || return 0 1/2 ✓
Checked 1 file
✔ No issues
trunk check --fix --print-failures moji.js 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for f00817a
trunk fmt moji.js || return 0 1/2 ✓
 ✔ Formatted moji.js
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures moji.js 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for d582fb1
trunk fmt moji.js || return 0 1/2 ✓
 ✔ Formatted moji.js
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures moji.js 2/2 ❌ (`1`)
  ISSUES  
moji.js:8:7
 8:7  high  'url' is assigned a value but never used.  eslint/no-unused-vars
Checked 1 file
✖ 1 new issue


Sandbox logs for 895fbc2
trunk fmt public_html/index.html || return 0 1/2 ✓
 ✔ Formatted public_html/index.html
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures public_html/index.html 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for 7a59520
trunk fmt docker-compose.yml || return 0 1/2 ✓
Checked 1 file
✔ No issues
trunk check --fix --print-failures docker-compose.yml 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for 7a59520
trunk fmt docker-compose.yml || return 0 1/2 ✓
 ✔ Formatted docker-compose.yml
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures docker-compose.yml 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for 895fbc2
trunk fmt docker-compose.yml || return 0 1/2 ✓
 ✔ Formatted docker-compose.yml
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures docker-compose.yml 2/2 ✓
  ISSUES  
docker-compose.yml:13:9
 13:9  high  string value is redundantly quoted with any quotes  yamllint/quoted-strings
Checked 1 file
1 existing issue


Sandbox logs for 7a59520
trunk fmt package.json || return 0 1/2 ✓
 ✔ Formatted package.json
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures package.json 2/2 ✓
Checked 1 file
✔ No issues


Sandbox logs for 7a59520
trunk fmt package.json || return 0 1/2 ✓
 ✔ Formatted package.json
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix --print-failures package.json 2/2 ✓
Checked 1 file
✔ No issues


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/add-url-parameter.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord