mikal-k / moji-the-decoder

0 stars 0 forks source link

Improved UI for ZWJ Emojis and Other Characters (βœ“ Sandbox Passed) #22

Open sweep-ai[bot] opened 7 months ago

sweep-ai[bot] commented 7 months ago

PR Feedback (click)

Please refer to the public_html/js/emojiDetails.js file for the key JavaScript functions involved in this update and the public_html/index.html file for the changes made to the front-end structure and layout.

Summary

Fixes #21.


πŸŽ‰ Latest improvements to Sweep:


πŸ’‘ To get Sweep to edit this pull request, you can:

sweep-ai[bot] commented 7 months ago

Sandbox Executions

Ran GitHub Actions for 96600672a9fcc48f85c40e0868cc39c8ad74a98a:

Ran GitHub Actions for 2d5cb99ab8d07ceaf6b88696c73dbd82d2c04b50:

Ran GitHub Actions for 42438723d6e7a10e9fb3fa76c4a63bfdb59ae987:

Ran GitHub Actions for a7d3ed853b5e4dd242a3f8bf988497e7e95eeb3d:

Ran GitHub Actions for bff6bac89e29f63bcfc9752278b353c7a4229516:

Ran GitHub Actions for db0b284396e2e915a84a74c0ae67752652cac347:

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

mikal-k commented 7 months ago

$ ξ‚° node moji.js node:internal/modules/cjs/loader:1147 throw err; ^

Error: Cannot find module 'express' Require stack:

Node.js v21.1.0

sweep-ai[bot] commented 7 months ago

πŸš€ Wrote Changes

Done.

mikal-k commented 7 months ago

Solved problem by changing ownership of moji-the-decoder/node_module. Now it starts:

node moji.js Moji server listening on port 2950! Component: πŸ‘οΈ, Name: (unknown), Codepoint: U+1F441 FE0F Component: πŸ—¨οΈπŸ€–, Name: (unknown), Codepoint: U+1F5E8 FE0F 1F916 Component: πŸ‘οΈ, Name: (unknown), Codepoint: U+1F441 FE0F Component: πŸ—¨οΈ, Name: (unknown), Codepoint: U+1F5E8 FE0F Component: πŸ‘οΈ, Name: (unknown), Codepoint: U+1F441 FE0F Component: πŸ—¨οΈ, Name: (unknown), Codepoint: U+1F5E8 FE0F

The UI doesn't decode πŸ‘οΈβ€πŸ—¨οΈ, but shows "Emoji name: undefined Codepoint: undefined" below the decode button (Which you have renamed Show details, please undo that)

sweep-ai[bot] commented 7 months ago

πŸš€ Wrote Changes

Done.

mikal-k commented 7 months ago

$ ξ‚° node moji.js Moji server listening on port 2950! Component: emoji-box.css, Name: (unknown), Codepoint: U+65 6D 6F 6A 69 2D 62 6F 78 2E 63 73 73 Component: emojiDetails.js, Name: (unknown), Codepoint: U+65 6D 6F 6A 69 44 65 74 61 69 6C 73 2E 6A 73 Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client at ServerResponse.setHeader (node:_http_outgoing:696:11) at ServerResponse.header (/home/mikal/git/moji-the-decoder/node_modules/express/lib/response.js:794:10) at ServerResponse.send (/home/mikal/git/moji-the-decoder/node_modules/express/lib/response.js:174:12) at ServerResponse.json (/home/mikal/git/moji-the-decoder/node_modules/express/lib/response.js:278:15) at /home/mikal/git/moji-the-decoder/moji.js:38:23 at Array.map () at /home/mikal/git/moji-the-decoder/moji.js:32:27 at Layer.handle [as handle_request] (/home/mikal/git/moji-the-decoder/node_modules/express/lib/router/layer.js:95:5) at next (/home/mikal/git/moji-the-decoder/node_modules/express/lib/router/route.js:144:13) at Route.dispatch (/home/mikal/git/moji-the-decoder/node_modules/express/lib/router/route.js:114:3)