mikalhart / IridiumSBD

Arduino library for RockBLOCK Iridium satellite modem (http://rock7mobile.com)
132 stars 52 forks source link

Callbacks not handled correctly when DIAGNOSTICS not defined. #24

Closed mikalhart closed 5 years ago

mikalhart commented 5 years ago

Due to a misunderstanding about how the "weak" attribute works, on certain platforms, sketches that do not have the callback functions defined crash.

Specifically, having a "weak" function declared and then not implementing it (weak or strong) anywhere, does not allow you to write code like this:

   if (ISBDConsoleCallback != NULL)
   {
         ISBDConsoleCallback(this, c);
   }
mikalhart commented 5 years ago

Fixed in release 2.0.0!