search

mikamai / akamai_api

Akamai gem+CLI to work with CCU and ECCU interfaces
MIT License
43 stars 19 forks source link

loosen savon dependency #25

Closed hynkle closed 9 years ago

hynkle commented 9 years ago

Previously this project required savon 2.5.x , which at this point is over a year old. The current version of savon is 2.11.1.

The project worked with no changes required with savon 2.6 and 2.7. A small change was required to make it work with savon 2.8–2.11: timestamps were coming through as DateTime objects rather than as iso8601 strings, so the get_if_string method in this project was returning nil for any timestamps.

I altered get_if_string to be called get_if_handleable and expanded it to work with DateTime objects as well as strings.

nicolaracco commented 9 years ago

Specs failed because there is an update to the aruba gem. I forced the gem version in master for the moment. Can you pull from master ?

hynkle commented 9 years ago

Done! Specs pass for me locally (though they also did before forcing the aruba version) and it looks like CI is happy now, too.

(Sorry it took me a week to get around to this!)

nicolaracco commented 9 years ago

Released as v0.4.1. Thank you