search

mikamai / akamai_api

Akamai gem+CLI to work with CCU and ECCU interfaces
MIT License
43 stars 19 forks source link

Relax thor dependency to a lower version #3

Closed nikosd closed 11 years ago

nikosd commented 11 years ago

Hi there, I was wondering if thor 0.16 is really required or if a lower version will also work. Currently I'm on rails 3.1.X which depends on ~> 0.14.6, a.k.a. no more than 0.14. Since there are no tests as I understand for the CLI part of this lib, would it be safe to lower it by hand?

Cheers and thanks for taking the time to write this piece of code so far - uber useful!

nikosd commented 11 years ago

(this is fixed on Rails 3.2.X but we are not ready to go there yet)

https://github.com/rails/rails/commit/7dc83f78232a6dfcdd70292e831403933f57347b#commitcomment-2061674

nikosd commented 11 years ago

And here is my temporary branch : https://github.com/e-travel/akamai_api/tree/thor_0.14_compatibility

nicolaracco commented 11 years ago

You are right, thor 0.16 is not really required. I just pushed a change to the gemspec to require "~> 0.14". Tell me if it's ok now :)

nikosd commented 11 years ago

To be able to use also 0.15 and 0.16 I would suggest '~> 0.14' instead of '~> 0.14.0' ;)

Thanks a lot for this!