search

mikaoj / BSImagePicker

A multiple image picker for iOS
MIT License
1.35k stars 379 forks source link

localizations function is incomplete on iOS platform #229

Closed hi-glenn closed 4 years ago

hi-glenn commented 4 years ago

As the title say, localizations function is incomplete on iOS platform.

My iOS simulator is already selecting simple-Chinese, however, upper-right corner still display English "Done".

And, I think a fraction like 2/3 will be better than only a number.

image

mikaoj commented 4 years ago

You have to localize Done yourself. Look into how localization works on iOS. But basically you create a localizable.strings and add "Done" = "做完了"; If you run into problems let me know and I'll see what I can do.

And as for 2/3 - sure that works. But the default is to allow Int.max selections (the maximum of a 64 bit int on most platforms) so 2/9,223,372,036,854,775,807 would look kind of bad ;)

hi-glenn commented 4 years ago

OK, I see.

Thanks for your timely response.

krummler commented 4 years ago

Hi there,

To follow up on that, would it be possible to make the used key configurable? We use a set of rules to define the keys used for translations. Currently this is a private let:

private let doneBarButtonTitle: String = NSLocalizedString("Done", comment: "Done")

Having a key "Done" doesn't match the rest and could be confusing for us. Would you mind changing this so a public var, so it can be overridden?

mikaoj commented 4 years ago

Yes - I have been meaning to change the key to something like BSImagePicker.done to distinguish it from similar keys that may already exist in the app.

Make it public and send a pull request :)