Closed lucascherzer closed 1 month ago
I have managed to kinda fix it via the following override in the main config:
"experimental.theme_overrides": {
"players": [
{
"selection": "#434c5e99"
}
]
}
Works for me! But this would affect other themes as well, right?
I have not had a look at zed's theming yet but can this simply be appended to the .themes[0].style.players[]
list in nord.json?
Would be nice to have this integrated directly into the theme so that we are not relying on theme overrides in the user config.
Yes, this override will affect all other themes. As for fixing it in the theme, I will leave it to the maintainer or someone more knowledgeable or dedicated, since it's likely to involve tweaking the colors in other players. My anxiety and ocd kicks in when I see so many parameters to test :D
@lucascherzer Will plan to do it later. Thanks for your suggestion and help!
@lucascherzer I couldn't reproduce it in a new Zed version (Zed 0.152.4) It's works fine 🤷🏻♂️
Maybe it was fixed in a new version. Could you please check? Try to update Zed.
Please try to select some text from the popup to see the issue. On your screenshot there is no selection inside the popup.
In PR https://github.com/zed-industries/extensions/pull/1437 Thanks guys!
I'm also running 0.152.4 and updated the extension. Highlighted text still has the same colour as the background and no transparency:
And I just noticed your PR to the extension repo is not yet merged. Nevermind my comment then
@lucascherzer Yeap, let's wait a little :)
It's a matter of taste, but with 0.0.9 the cursor became barely distinguishable from the background, so I had to force "cursor": "#6e91bf"
for the first player ;D
The highlight color is the same as the background color and not transparent No highlighting:
When highlighting: