search

mikasius / zed-nord-theme

Nord theme for zed
13 stars 6 forks source link

Search Highlight Contrast & Other General Highlighting #4

Open Taklop opened 3 months ago

Taklop commented 3 months ago

Thanks so much for creating this, Nord is one of my fave themes!

I just had a little feedback for a couple of things I noticed:

Search

When searching in a file, the highlighted matches are very hard to spot currently. The "currently" highlighted match is okay-enough, but the other matches could maybe be more contrasty.

Below is a comparison of Nord in Zed vs Nord in vscode:

Zed Nord

CleanShot 2024-04-15 at 12 19 37

VSCode Nord

CleanShot 2024-04-15 at 12 17 48

General Highlighting

It seems that the zed implementation of Nord doesn't use as much of the palette as it could to help differentiate items & add contrast. (Some areas it is better than the VSCode version though!

I'm unsure if this is a limitation in Zed, the langserver / svelte plugin though, but thought I'd mention. Here are some examples

Zed Vs VSCode Nord

CleanShot 2024-04-15 at 12 27 07

mikasius commented 2 months ago

@Taklop Thank you for this detailed overview! Right now a have not much time to develop this. I'll returned to this later. If you have a time, you could create a PR for this changes and I will merge it. :)