search

mikavilpas / yazi.nvim

A Neovim Plugin for the yazi terminal file manager
MIT License
467 stars 16 forks source link

Remove bufferline dependency #334

Closed knmac closed 1 month ago

knmac commented 2 months ago

I found that yazi.nvim only uses one file from bufferline.nvim, so I added that file here to make the package self-contained. Could you please merge this PR if it looks good? Thanks!

mikavilpas commented 1 month ago

It's a good idea. Thanks!

mikavilpas commented 1 month ago

Actually, I realized I should not be using bufferline for adjusting colors due to license conflicts. It seems to be licensed under GPLv3 while this project is MIT. It would require re-licensing this project as GPLv3, which I think I don't have the right to as I don't hold the copyright to all the code (some of it is written by others).

In my experience not many care about license violations until significant money is involved, but it would be better to avoid any issues altogether. Dealing with software licenses does not really "spark joy" for me, so I would prefer not having to do that at all. As a side note, the popular LazyVim might be in violation too 🤔

I think a good alternative implementation might be available here https://github.com/catppuccin/nvim/blob/main/lua/catppuccin/utils/colors.lua with the MIT license.

I think I will refactor the code to use that instead. Still, it will probably be a good idea to embed and the implementation and strip it down to the bare minimum.

mikavilpas commented 1 month ago

I think I can still use this PR to make the future change, so I'll keep this open for now.

mikavilpas commented 1 month ago

Okay I think I was able to trim down everything to the bare minimum. Thanks for the idea!