search

mikavilpas / yazi.nvim

A Neovim Plugin for the yazi terminal file manager
MIT License
465 stars 16 forks source link

Fix Windows spaces issue #73

Closed Kayzels closed 4 months ago

Kayzels commented 4 months ago

This just replaces \ (backslash followed by space) with ` (space), which solves #67. What was causing the issue was thatfnameescape` added the backslashes in front of the existing spaces, so Windows got confused.

It also changes the function that checks for the Yazi version, because Yazi added a CSI sequence in sxyazi/yazi@4c35f26e in front (which is what was leading to the weird characters at the start).

mikavilpas commented 4 months ago

Nice work!

I'm not sure if I actually made things worse with e375060189714aa8462018c3c59c8096102ce974. I added logic for escaping the path on windows in that commit although the double quotes are already in place.

But if it works for you, then maybe it doesn't need more changes. We can always adjust it in the future if need be.

Kayzels commented 4 months ago

Not sure why the one test keeps failing. Seems to be some issue with usr/bin/git, so not sure if I need to do something?

mikavilpas commented 4 months ago

Hmm this has never happened before, and I think the changes are very well contained and minimal. Maybe it's a temporary issue.

I will keep trying.

Kayzels commented 4 months ago

Maybe it's trying to find it in your repo, rather than from an external one? Have there been any pull requests done for this repo by someone other than you?

mikavilpas commented 4 months ago

Yeah, there have been a couple 🤔

mikavilpas commented 4 months ago

I'm not sure what was wrong with that, but it seems to work in #74. Let's continue there :)