search

mike-goodwin / owasp-threat-dragon-core

OWASP Threat Dragon core files
Apache License 2.0
11 stars 16 forks source link

It's impossible to zoom in on items on the right or bottom of the diagram. #72

Closed meetinthemiddle-be closed 4 years ago

meetinthemiddle-be commented 4 years ago

The zoom "+" and "-" buttons scale the diagram with the top left corner as an anchor point, so zooming in pushes items on right and bottom out of the viewport. For bigger diagrams, this may become a usability issue.

Proposals for improvement:

Preferred : Add a "hand" icon that allows you to drag the view to add pan functionality (most intuitive)

Alternatively : When an element is selected, use a point on the selected element to serve as anchor point for the zoom operation instead of the top-left corner.

jgadsden commented 4 years ago

Hello @meetinthemiddle-be Very good suggestions, it would be good to have both the 'hand' and also to centre the zoom on the selected element (if one is selected). We are looking for contributors, and this enhancement would make a good self-contained task

jgadsden commented 4 years ago

transferring this issue to repo: https://github.com/mike-goodwin/owasp-threat-dragon-core/issues as this is the main diagram repo for both desktop and web application versions

jgadsden commented 4 years ago

On zoom the scrollbars do not update to follow the changing view scope. Hence zooming in means that some of the diagram is inaccessible

jgadsden commented 4 years ago

Hello @meetinthemiddle-be This issue is part of a larger problem with the zoom feature, as is the issue #73 . We are removing zoom feature temproarily in #94 and will reinstate it when zoom is working fully, tracked by issue #95 . Thanks for raising both these issues, and I hope it is OK to close your issue as it is now part of #95