mike-goodwin / owasp-threat-dragon-desktop

An installable desktop variant of OWASP Threat Dragon
Apache License 2.0
594 stars 89 forks source link

Diagram Panel Resizing #141

Open iphelix opened 4 years ago

iphelix commented 4 years ago

The graph panel does not expand vertically when zoomed out leaving most of the diagram cut off.

jgadsden commented 4 years ago

Hello @iphelix - can you check what version of Threat Model you are using? There was a lot of trouble with zoom in/out, and zoom is disabled in version 1.2 for this reason: https://github.com/mike-goodwin/owasp-threat-dragon-desktop/releases/tag/v1.2

Could you make sure you are using version 1.2, and this problem should no longer be there?

iphelix commented 4 years ago

Yep, confirmed it's for the latest 1.2 version for Mac.

jgadsden commented 4 years ago

Thanks for the confirmation. How are you zooming the diagram in and out? Could you send a screen shot so I could understand the view? Thanks again

iphelix commented 4 years ago

Zooming in and out using menu bar or command/ - or + keys. The issue is that as the objects resize they don't automatically expand vertically leaving the bottom half of the window empty.

Screen Shot 2020-06-24 at 10 28 13 AM
jgadsden commented 4 years ago

Hello @iphelix - thanks, I understand now. We had disabled the zoom in / out for the diagram itself, but you make the good point that zooming the entire application in and out does not work as it should. Will try and see how to fix this, unless you have a solution already? We always welcome any contributions if you have one

bigbrett commented 4 years ago

+1 for this issue. This isn't just a MacOS issue too, the feature doesn't exist in the Linux App Image either